Report positionless tsconfig option errors on compilerOptions key
#58254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
requested review from
DanielRosenwasser,
sheetalkamat and
jakebailey
andrewbranch
commented
Apr 19, 2024
Comment on lines
7
to
+9
| "compilerOptions": { | ||
| ~~~~~~~~~~~~~~~~~ | ||
| !!! error TS5095: Option 'bundler' can only be used when 'module' is set to 'preserve' or to 'es2015' or later. |
There was a problem hiding this comment.
Note that this test is simulating a combination of tsconfig options and CLI flags. This would have been reported on "moduleResolution": "bundler" if it were in the tsconfig, but it was passed in as a flag instead.
jakebailey
reviewed
Apr 19, 2024
...ines/reference/resolutionCandidateFromPackageJsonField2(moduleresolution=bundler).errors.txt
Show resolved
Hide resolved
sheetalkamat
requested changes
Apr 19, 2024
sheetalkamat
approved these changes
Apr 19, 2024
RyanCavanaugh
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any program error that is talking about a compiler option but can’t find an option name/value to report the error on now reports the error on the
compilerOptionskey (if present) instead of positionlessly in the file. I noticed while investigating #58214 that these positionless errors are very easy to miss in the editor.Before:
After:
A common one that’s still positionless is “Cannot write file 'foo.js' because it would overwrite input file.” We could consider moving that to
compilerOptionstoo since the correct fix is to add eitheroutDirornoEmit99% of the time, along with suggesting that in the error message. Anyone have opinions on that?